Messages in this thread | | | Date | Tue, 5 Jan 2016 12:27:09 -0300 | Subject | Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions | From | "Geyslan G. Bem" <> |
| |
2016-01-05 12:23 GMT-03:00 Joe Perches <joe@perches.com>: > On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote: >> On Mon, 4 Jan 2016, Geyslan G. Bem wrote: >> >> > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd *ehci, __hc32 token) >> > >> return '/'; >> > >> } >> > >> >> > >> -static void qh_lines( >> > >> - struct ehci_hcd *ehci, >> > >> - struct ehci_qh *qh, >> > >> - char **nextp, >> > >> - unsigned *sizep >> > >> -) >> > >> +static void qh_lines(struct ehci_hcd *ehci, struct ehci_qh *qh, >> > >> + char **nextp, unsigned *sizep) >> > >> { >> > >> u32 scratch; >> > >> u32 hw_curr; >> > >> >> > > >> > And about that style? Should be done? >> >> You mean squeezing the function parameters into two lines? That's >> okay. Yes. I'll change this patch to do only that squeezing.
>> >> However, the style in this file is to indent continuation lines by two >> extra tab stops, not to line things up with an open paren on the first >> line. I see. I used 3 tabs, reducing to 2.
> > It's not consistent. > It's a bit of a mix of 1 and 2 tabs, and some others. I noticed it. Maybe to avoid the 80th column there are 1 tab indentations.
> >
-- Regards,
Geyslan G. Bem hackingbits.com
| |