lkml.org 
[lkml]   [2016]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions
On Mon, 4 Jan 2016, Geyslan G. Bem wrote:

> >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd *ehci, __hc32 token)
> >> return '/';
> >> }
> >>
> >> -static void qh_lines(
> >> - struct ehci_hcd *ehci,
> >> - struct ehci_qh *qh,
> >> - char **nextp,
> >> - unsigned *sizep
> >> -)
> >> +static void qh_lines(struct ehci_hcd *ehci, struct ehci_qh *qh,
> >> + char **nextp, unsigned *sizep)
> >> {
> >> u32 scratch;
> >> u32 hw_curr;
> >>
> >
> And about that style? Should be done?

You mean squeezing the function parameters into two lines? That's
okay.

However, the style in this file is to indent continuation lines by two
extra tab stops, not to line things up with an open paren on the first
line.

Alan Stern



\
 
 \ /
  Last update: 2016-01-05 17:01    [W:0.086 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site