Messages in this thread | | | Date | Tue, 5 Jan 2016 15:17:57 +0100 (CET) | From | Julia Lawall <> | Subject | Re: [PATCH v6] coccinelle: tests: unsigned value cannot be lesser than zero |
| |
> +@script:python depends on org@ > +p << r_cmp.p; > +e << r.e = ""; > +@@ > + > +msg = "WARNING: Unsigned expression compared with zero: %s" % (e) > +coccilib.org.print_todo(p[0], msg) > + > +@script:python depends on report@ > +p << r_cmp.p; > +e << r.e = ""; > +@@ > + > +msg = "WARNING: Unsigned expression compared with zero: %s" % (e) > +if e: > + coccilib.report.print_report(p[0], msg)
Is it intentional that these don't do the same thing? The report case has an if on e, while the org case does not. If you don't want a report when e doesn't have a value, you could just remove the = "" from the declaration of e. That is to give a default value of e, to allow the rule to be executed when e doesn't have a value.
julia
| |