lkml.org 
[lkml]   [2016]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()
    Btw, GCC misses a lot of uninitialized variable bugs.  I have a Smatch
    check which sometimes catches the bugs that GCC misses but you should
    not rely on the tools here. These patches need to be reviewed manually.

    And the "goto err" before the initialization makes everything more
    complicated (that's actually what caused the bug in this patch, in fact).

    regards,
    dan carpenter



    \
     
     \ /
      Last update: 2016-01-04 11:21    [W:4.029 / U:0.568 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site