Messages in this thread | | | Date | Mon, 4 Jan 2016 12:38:29 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() |
| |
Btw, GCC misses a lot of uninitialized variable bugs. I have a Smatch check which sometimes catches the bugs that GCC misses but you should not rely on the tools here. These patches need to be reviewed manually.
And the "goto err" before the initialization makes everything more complicated (that's actually what caused the bug in this patch, in fact).
regards, dan carpenter
| |