lkml.org 
[lkml]   [2016]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a bit)
On Mon, Jan 4, 2016 at 3:02 PM, Borislav Petkov <bp@alien8.de> wrote:
> On Mon, Jan 04, 2016 at 02:29:09PM -0800, Andy Lutomirski wrote:
>> Josh will argue with you if he sees that :)
>
> Except Josh doesn't need allyesconfigs. tinyconfig's __ex_table is 2K.

If we do the make-it-bigger approach, we get a really nice
simplification. Screw the whole 'class' idea -- just store an offset
to a handler.

bool extable_handler_default(struct pt_regs *regs, unsigned int fault,
unsigned long error_code, unsigned long info)
{
if (fault == X86_TRAP_MC)
return false;

...
}

bool extable_handler_mc_copy(struct pt_regs *regs, unsigned int fault,
unsigned long error_code, unsigned long info);
bool extable_handler_getput_ex(struct pt_regs *regs, unsigned int
fault, unsigned long error_code, unsigned long info);

and then shove ".long extable_handler_whatever - ." into the extable entry.

Major bonus points to whoever can figure out how to make
extable_handler_iret work -- the current implementation of that is a
real turd. (Hint: it's not clear to me that it's even possible
without preserving at least part of the asm special case.)

--Andy


\
 
 \ /
  Last update: 2016-01-05 01:01    [W:0.065 / U:3.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site