Messages in this thread | | | From | Joao Martins <> | Subject | Re: [Xen-devel] [PATCH RFC 3/3] xen/Kconfig: add XEN_TIME_VSYSCALL option | Date | Mon, 4 Jan 2016 20:41:24 +0000 |
| |
On 01/04/2016 04:15 PM, Boris Ostrovsky wrote: > On 01/04/2016 11:12 AM, David Vrabel wrote: >> On 28/12/15 21:52, Joao Martins wrote: >>> This option enables support for pvclock vsyscall/vdso >>> support on Xen. Default is off, since Xen doesn't >>> expose yet the PVCLOCK_TSC_STABLE_BIT flag. >> Do we need a Kconfig option for this? I think this should always be >> enabled. >> >> The kernel support won't be merged until the hypervisor changes have >> been accepted. > I agree. xen_setup_vsyscall_time_info() will (harmlessly) fail if > PVCLOCK_TSC_STABLE_BIT is not set. > OK, I will remove this patch then.
I only added it because even if PVCLOCK_TSC_STABLE_BIT is not supported it would leave the pvti registered with Xen during domain lifetime [it seems we can't unregister the pvti]. But perhaps this is not a concern.
> -boris >
| |