Messages in this thread | | | Date | Mon, 4 Jan 2016 11:24:42 -0700 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v3 2/7] tpm_tis: Disable interrupt auto probing on a per-device basis |
| |
On Sun, Jan 03, 2016 at 07:20:40PM +0200, Jarkko Sakkinen wrote: > On Thu, Dec 17, 2015 at 11:23:15AM -0700, Jason Gunthorpe wrote: > > Instead of clearing the global interrupts flag when any device > > does not have an interrupt just pass -1 through tpm_info.irq. > > > > The only thing that asks for autoprobing is the force=1 path. > > Sorry for my ignorance but what does this patch help? Why interrupts > flag is not enough?
It is wrong for a driver's probe function to change global state, and very wrong to change a module option.
> > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > > Tested-by: Wilck, Martin <martin.wilck@ts.fujitsu.com> > > Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > Did I already give Tested-by's for this series (I did for those that > went into v4.5 pull request)?
You said you tested the crb stuff, which is this series... Did you test something else?
Jason
| |