Messages in this thread | | | From | Andy Lutomirski <> | Date | Mon, 4 Jan 2016 10:23:52 -0800 | Subject | Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid |
| |
On Wed, Dec 30, 2015 at 3:27 AM, Michał Kępień <kernel@kempniu.pl> wrote: >> > If you feel like I'm nit-picking and none of the above matters, >> > please feel free to disregard my input and just follow your gut. >> >> It's ok. We just understand it quite differently. And in this case what >> about changing commit message to something like this? >> >> === >> dell-wmi: Check if Dell WMI descriptor structure is valid >> >> After examining existing DSDT ACPI tables of more laptops and looking >> into Dell WMI document mentioned in ML dicussion archived at >> http://www.spinics.net/lists/platform-driver-x86/msg07220.html we will >> parse and check WMI descriptor if contains expected data. It is because >> WMI descriptor contains interface version number and it is needed to >> know in next commit. >> === > > I like it way more than the previous one. >
FWIW, the original version of this series works fine on my laptop (after fixing the separate dmi_walk misuse bug).
--Andy
| |