Messages in this thread | | | From | Phil Edworthy <> | Subject | RE: [PATCH 2/4] PCI: rcar: Support runtime PM link state L1 handling in pcie-rcar | Date | Mon, 4 Jan 2016 14:18:12 +0000 |
| |
Hi Geert,
On 21 December 2015 13:17, Geert Uytterhoeven wrote: > On Mon, Dec 21, 2015 at 11:52 AM, Phil Edworthy > <phil.edworthy@renesas.com> wrote: > > On 18 December 2015 14:04, Wolfram Sang wrote: > >> > Since the hardware doesn't support hot plug, I believe this loop will > >> > always exit very quickly. Unless someone has taken a hammer to the HW > >> > of course. > >> > >> I know what you mean. But since readl_poll_timeout() makes it easy, we > >> should better be safe than sorry. > > Hmm, I changed the code, but now it doesn't come out of suspend unless > > sleep_us passed to readl_poll_timeout is 0. Any reason you can think of? > > Timers or interrupts disabled? > > Does the might_sleep_if() scream if CONFIG_DEBUG_ATOMIC_SLEEP=y? Yes, it does indeed scream. Would you recommend to still use readl_poll_timeout with sleep_us set to 0?
Thanks Phil
| |