lkml.org 
[lkml]   [2016]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()
    From
    Date
    >> May I resend a consistent patch series for the source file
    >> "drivers/net/wireless/rsi/rsi_91x_pkt.c" in the near future?
    >
    > If you were sending checkpatch.pl fixes that would be easier to deal with

    Does this feedback mean that you would accept any more suggestions around
    source code updates which are derived from recommendations of this script?


    > but you are sending hundreds of "controversial" cleanups.

    It depends on the time range you look at for my proposals.


    > They are controversial in the sense that they don't fix anything
    > against official kernel style

    I find that I suggested also few changes that fit to this aspect.


    > and they go against the author's original intention.

    Can it occasionally help to reconsider the "first approach"?


    > I tend to agree that useless initializers are bad

    Would any more software developers like to share their opinions on this detail?


    > and disable GCCs uninitialized variable warnings

    I hope that this software area can be also improved.


    > but just because I agree with you doesn't make it official kernel style.

    That is fine. - Will it become useful to clarify any extensions
    to a document like "CodingStyle"?


    > It's slightly rude to go against the author's intention.

    I just dare to propose further special changes.

    Regards,
    Markus



    \
     
     \ /
      Last update: 2016-01-04 13:41    [W:4.277 / U:0.744 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site