lkml.org 
[lkml]   [2016]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] 390/qeth: Delete an unnecessary variable initialisation in qeth_core_set_online()
    On Sun, Jan 03, 2016 at 11:02:00AM +0100, SF Markus Elfring wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Sun, 3 Jan 2016 10:48:05 +0100
    >
    > Omit explicit initialisation at the beginning for one local variable
    > that is redefined before its first use.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/s390/net/qeth_core_main.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
    > index 7871537..54fde2e 100644
    > --- a/drivers/s390/net/qeth_core_main.c
    > +++ b/drivers/s390/net/qeth_core_main.c
    > @@ -5637,7 +5637,7 @@ static void qeth_core_remove_device(struct ccwgroup_device *gdev)
    > static int qeth_core_set_online(struct ccwgroup_device *gdev)
    > {
    > struct qeth_card *card = dev_get_drvdata(&gdev->dev);
    > - int rc = 0;
    > + int rc;
    > int def_discipline;

    You can generate hundreds of patches like this one. There are even plenty
    more opportunities within this same file. I don't think we need this.

    If at all then change all occurrences within a file at once, but that is
    Ursula's call.



    \
     
     \ /
      Last update: 2016-01-04 13:01    [W:4.123 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site