Messages in this thread | | | Date | Sat, 30 Jan 2016 18:40:30 +0100 | From | Mathieu OTHACEHE <> | Subject | Re: [PATCH v2 1/4] USB: mxu11x0: fix memory leak on usb_serial private data |
| |
On Mon, Jan 25, 2016 at 01:01:59PM +0100, Johan Hovold wrote: > On Mon, Jan 04, 2016 at 07:49:36PM +0100, Mathieu OTHACEHE wrote: > > On nominal execution, private data allocated on port_probe and attach > > are never freed. Add port_remove and release callbacks to free them > > respectively. > > > > Signed-off-by: Mathieu OTHACEHE <m.othacehe@gmail.com> > > I've applied this one for 4.5-rc2 now. > > I want to take a closer look at the last three patches and it seems they > should wait for 4.6 anyway. I did notice that the vendor driver also > sends double START/OPEN commands at open by the way. Perhaps ask Moxa > why that is before we remove them? > > Thanks, > Johan
Hi Johan,
I asked MOXA about this double opening. I also noticed that the mainline driver ti_usb_3410_5052 uses the same double opening pattern. And, MOXA UPORT 11x0 serie is based on TUSB3410 chip of TI.
So, I also emailed TI, and the authors of ti_usb_3410_5052 driver.
I keep you informed,
Thank you
Mathieu
| |