lkml.org 
[lkml]   [2016]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/4] netfilter: ipv4: use preferred kernel types
    From
    On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy <kaber@trash.net> wrote:
    > On 30.01, Lucas Tanure wrote:
    >> As suggested by checkpatch.pl:
    >> CHECK: Prefer kernel type 'uX' over 'uintX_t'
    >
    > You might have noticed we have literally hundreds of them spread over 100
    > files in the netfilter code. We'll gradually change them when the code is
    > touched anyways.
    >
    >> net/ipv4/netfilter/ip_tables.c | 5 ++---
    >> 1 file changed, 2 insertions(+), 3 deletions(-)

    Yes, I checked that. But would be better to change that now?
    Because:
    - could take years to anyone to touch the code, as the code already
    works very well
    - be more standardized could facilitate reading the code
    - It's a good way to encourage new people to contribute to the code

    Thanks!

    \
     
     \ /
      Last update: 2016-01-30 15:21    [W:3.272 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site