Messages in this thread | | | Subject | Re: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init() | From | SF Markus Elfring <> | Date | Sun, 3 Jan 2016 19:16:49 +0100 |
| |
>> I prefer that assignments for variables like "card" and "slic_regs" >> will only be performed immediately before the corresponding content will be >> read again (after a few condition checks were executed). >> >> Another description could be this view: >> I suggest to move the variable initialisation a bit. > > And like David Miller and others just said, please don't bother us with > pointless patches such as this, if you keep it up, I'll have to add you > to my killfile as patches like this are a waste of everyone's valuable time.
I am a bit surprised that you do not like such source code fine-tuning. Will related software improvements get another chance later (eventually together with other changes)?
Regards, Markus
| |