lkml.org 
[lkml]   [2016]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tpmdd-devel] [PATCH] tpm, tpm_crb: fix control area resource mapping
On Fri, Jan 29, 2016 at 03:33:34PM -0700, Jason Gunthorpe wrote:
> On Fri, Jan 29, 2016 at 02:26:54PM -0800, Jarkko Sakkinen wrote:
> > On Fri, Jan 29, 2016 at 02:21:08PM -0800, Jarkko Sakkinen wrote:
> > > On Fri, Jan 29, 2016 at 01:48:27PM -0700, Jason Gunthorpe wrote:
> > > > On Thu, Jan 28, 2016 at 11:13:59PM -0800, Jarkko Sakkinen wrote:
> > > >
> > > > > - struct resource tmp = {};
> > > > > -
> > > > > - tmp.start = start;
> > > > > - tmp.end = start + size - 1;
> > > > > - tmp.flags = IORESOURCE_MEM;
> > > > > + struct resource new_res = {
> > > > > + .start = start,
> > > > > + .end = size - 1,
> > > >
> > > > That isn't right.
> > >
> > > Whoops. Good catch, I'll update it before pull request. Thanks!
> >
> > github.com/jsakkine/linux-tpmdd/commit/5012960093774c49d81c612eb32f92cfa1f619bc
> >
> > struct resource new_res = {
> > .start = start,
> > .end = start + size - 1,
> > .flags = IORESOURCE_MEM,
> > };
> >
> > Better?
>
> Yes that looks ok

Thanks. To be extra sure I'll run smoke test and inject prints.

Acked-by?

> Jason

/Jarkko

\
 
 \ /
  Last update: 2016-01-30 00:01    [W:0.026 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site