lkml.org 
[lkml]   [2016]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 5/3] mm, vmscan: make zone_reclaimable_pages more precise
    From
    Date
    Michal Hocko wrote:
    > On Fri 29-01-16 19:35:18, Tetsuo Handa wrote:
    > > Michal Hocko wrote:
    > > > From: Michal Hocko <mhocko@suse.com>
    > > >
    > > > zone_reclaimable_pages is used in should_reclaim_retry which uses it to
    > > > calculate the target for the watermark check. This means that precise
    > > > numbers are important for the correct decision. zone_reclaimable_pages
    > > > uses zone_page_state which can contain stale data with per-cpu diffs
    > > > not synced yet (the last vmstat_update might have run 1s in the past).
    > > >
    > > > Use zone_page_state_snapshot in zone_reclaimable_pages instead. None
    > > > of the current callers is in a hot path where getting the precise value
    > > > (which involves per-cpu iteration) would cause an unreasonable overhead.
    > > >
    > > > Suggested-by: David Rientjes <rientjes@google.com>
    > > > Signed-off-by: Michal Hocko <mhocko@suse.com>
    > > > ---
    > > > mm/vmscan.c | 14 +++++++-------
    > > > 1 file changed, 7 insertions(+), 7 deletions(-)
    > > >
    > >
    > > I didn't know http://lkml.kernel.org/r/20151021130323.GC8805@dhcp22.suse.cz
    > > was forgotten. Anyway,
    >
    > OK, that explains why this sounded so familiar. Sorry I comepletely
    > forgot about it.
    >
    > > Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
    >
    > Can I change it to your Signed-off-by?

    No problem.

    >
    > --
    > Michal Hocko
    > SUSE Labs
    >

    \
     
     \ /
      Last update: 2016-01-29 23:01    [W:4.071 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site