lkml.org 
[lkml]   [2016]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 208/210] xen-netfront: respect user provided max_queues
    Date
    3.19.8-ckt14 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Wei Liu <wei.liu2@citrix.com>

    [ Upstream commit 32a844056fd43dda647e1c3c6b9983bdfa04d17d ]

    Originally that parameter was always reset to num_online_cpus during
    module initialisation, which renders it useless.

    The fix is to only set max_queues to num_online_cpus when user has not
    provided a value.

    Signed-off-by: Wei Liu <wei.liu2@citrix.com>
    Cc: David Vrabel <david.vrabel@citrix.com>
    Reviewed-by: David Vrabel <david.vrabel@citrix.com>
    Tested-by: David Vrabel <david.vrabel@citrix.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/net/xen-netfront.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
    index 76ce69c..e315fee 100644
    --- a/drivers/net/xen-netfront.c
    +++ b/drivers/net/xen-netfront.c
    @@ -2229,8 +2229,11 @@ static int __init netif_init(void)

    pr_info("Initialising Xen virtual ethernet driver\n");

    - /* Allow as many queues as there are CPUs, by default */
    - xennet_max_queues = num_online_cpus();
    + /* Allow as many queues as there are CPUs if user has not
    + * specified a value.
    + */
    + if (xennet_max_queues == 0)
    + xennet_max_queues = num_online_cpus();

    return xenbus_register_frontend(&netfront_driver);
    }
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-01-29 03:01    [W:4.233 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site