Messages in this thread | | | Date | Fri, 29 Jan 2016 01:16:03 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v4 1/2] regulator: act8945a: add regulator driver for ACT8945A |
| |
On Wed, Jan 27, 2016 at 10:57:42AM +0800, Wenyou Yang wrote:
> +static const struct of_device_id act8945a_pmic_of_match[] = { > + { .compatible = "active-semi,act8945a-regulator" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, act8945a_pmic_of_match);
This seems mostly OK but why do we have a compatible string here - shouldn't the MFD be able to instantiate the regulator function without needing this? [unhandled content-type:application/pgp-signature] | |