Messages in this thread | | | Date | Fri, 29 Jan 2016 00:13:06 +0100 | From | Mark Brown <> | Subject | Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator |
| |
On Thu, Jan 28, 2016 at 07:13:48PM +0100, John Crispin wrote:
> would the following two bindings be ok ? I would create patches to add them.
> * regulator-allow-mode; or regulator-allow-change-mode;
This seems redundant, if we have a list of valid modes presumably they can be used - same idea as with voltage setting.
> * regulator-modes = <REGULATOR_MODE_NORMAL REGULATOR_MODE_STANDBY>;
I'm not convinced this binding makes sense, how would a user of the API (currently there are none in tree) know what the modes mean? It's a bit different when the user is supplying configuration for a specific regulator but this needs to be something that can be used by consumers.
What are you actually trying to do with this? [unhandled content-type:application/pgp-signature] | |