Messages in this thread | | | Subject | Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2) | From | Namhyung Kim <> | Date | Thu, 28 Jan 2016 17:42:34 +0900 |
| |
On January 28, 2016 5:14:39 PM GMT+09:00, Jiri Olsa <jolsa@redhat.com> wrote: >On Thu, Jan 28, 2016 at 12:40:47AM +0900, Namhyung Kim wrote: >> Hello, >> >> This patchset tries to implement percent limit to callchains which >was >> requested by Andi Kleen. For some reason, limiting callchains by >> (overhead) percentage didn't work well. This patch fixes it and make >> --percent-limit also works for callchains as well as hist entries. >> >> * Changes from v1) >> - fix insertion path instead of changing all UI code >> - show percent value even on single path (if needed) >> - change default callchain percent limit >> >> This is available on 'perf/callchain-limit-v2' branch in my tree: >> >> >git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git >> >> Any comments are welcome, >> >> Thanks, >> Namhyung >> *** BLURB HERE *** >> >> Namhyung Kim (10): >> perf hists: Fix min callchain hits calculation >> perf hists: Update hists' total period when adding entries >> perf report: Apply --percent-limit to callchains also >> perf report: Get rid of hist_entry__callchain_fprintf() >> perf tools: Pass parent_samples to __callchain__fprintf_graph() >> perf report: Fix percent display in callchains on --stdio >> perf hists browser: Fix dump to show correct callchain style >> perf hists browser: Pass parent_total to callchain print functions >> perf hists browser: Fix percent display in callchains >> perf tools: Change default calchain percent limit to 0.005% > >heya, >do I get it right that: > >'perf report' display all entries, but only callchains above default >limit > >'perf report --percent-limit X' display only entries above limit X plus >only callchains above limit X > > >thanks, >jirka
Yes, actually there're two limits and they have different defaults. The --percent-limit sets both limits while -g only sets callchain limit.
Thanks Namhyung -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
| |