lkml.org 
[lkml]   [2016]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 008/210] [media] media: dvb-core: Don't force CAN_INVERSION_AUTO in oneshot mode
    Date
    3.19.8-ckt14 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Malcolm Priestley <tvboxspy@gmail.com>

    commit c9d57de6103e343f2d4e04ea8d9e417e10a24da7 upstream.

    When in FE_TUNE_MODE_ONESHOT the frontend must report
    the actual capabilities so user can take appropriate
    action.

    With frontends that can't do auto inversion this is done
    by dvb-core automatically so CAN_INVERSION_AUTO is valid.

    However, when in FE_TUNE_MODE_ONESHOT this is not true.

    So only set FE_CAN_INVERSION_AUTO in modes other than
    FE_TUNE_MODE_ONESHOT

    Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/media/dvb-core/dvb_frontend.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c
    index 2cf3057..61b9415 100644
    --- a/drivers/media/dvb-core/dvb_frontend.c
    +++ b/drivers/media/dvb-core/dvb_frontend.c
    @@ -2214,9 +2214,9 @@ static int dvb_frontend_ioctl_legacy(struct file *file,
    dev_dbg(fe->dvb->device, "%s: current delivery system on cache: %d, V3 type: %d\n",
    __func__, c->delivery_system, fe->ops.info.type);

    - /* Force the CAN_INVERSION_AUTO bit on. If the frontend doesn't
    - * do it, it is done for it. */
    - info->caps |= FE_CAN_INVERSION_AUTO;
    + /* Set CAN_INVERSION_AUTO bit on in other than oneshot mode */
    + if (!(fepriv->tune_mode_flags & FE_TUNE_MODE_ONESHOT))
    + info->caps |= FE_CAN_INVERSION_AUTO;
    err = 0;
    break;
    }
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-01-29 03:41    [W:4.521 / U:0.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site