lkml.org 
[lkml]   [2016]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from hot-path
    On 28-01-16, 12:55, Shilpasri G Bhat wrote:
    > cpu_to_chip_id() does a DT walk through to find out the chip id by
    > taking a contended device tree lock. This adds an unnecessary overhead
    > in a hot path. So instead of calling cpu_to_chip_id() everytime cache
    > the chip ids for all cores in the array 'core_to_chip_map' and use it
    > in the hotpath.
    >
    > Reported-by: Anton Blanchard <anton@samba.org>
    > Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
    > ---
    > Changes from v6:
    > - Minor changes to move the code 'cpumask_copy()' after 'core_to_chip_map'
    > is allocated.
    > - Move 'kfree(chips)' to a separate patch.

    See, you weren't that bad :)

    Just that you missed saying that individual patches contain
    version-log in cover-letter :)

    Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

    --
    viresh

    \
     
     \ /
      Last update: 2016-01-28 10:01    [W:4.111 / U:0.436 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site