lkml.org 
[lkml]   [2016]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 112/210] cifs_dbg() outputs an uninitialized buffer in cifs_readdir()
    Date
    3.19.8-ckt14 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Vasily Averin <vvs@virtuozzo.com>

    commit 01b9b0b28626db4a47d7f48744d70abca9914ef1 upstream.

    In some cases tmp_bug can be not filled in cifs_filldir and stay uninitialized,
    therefore its printk with "%s" modifier can leak content of kernelspace memory.
    If old content of this buffer does not contain '\0' access bejond end of
    allocated object can crash the host.

    Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
    Signed-off-by: Steve French <sfrench@localhost.localdomain>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    fs/cifs/readdir.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c
    index c295338..c4be623 100644
    --- a/fs/cifs/readdir.c
    +++ b/fs/cifs/readdir.c
    @@ -845,6 +845,7 @@ int cifs_readdir(struct file *file, struct dir_context *ctx)
    * if buggy server returns . and .. late do we want to
    * check for that here?
    */
    + *tmp_buf = 0;
    rc = cifs_filldir(current_entry, file, ctx,
    tmp_buf, max_len);
    if (rc) {
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-01-29 03:41    [W:4.215 / U:0.540 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site