lkml.org 
[lkml]   [2016]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file
Hi Maarten,

2016-01-27 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>:

> Hey,
>
> Op 27-01-16 om 14:30 schreef Gustavo Padovan:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >
> > sync_file is useful to connect one or more fences to the file. The file is
> > used by userspace to track fences.
> >
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >
> Is there a value in keeping the abi unchanged?
> If not, then Documentation/ioctl/botching-up-ioctls.txt is worth a read.

None from me. I'll look where we can improve the ABI.

>
> Looking at the patch, it seems you kept SYNC_IOC_WAIT, won't it be better to remove it, and only support waiting with polling?
> The code for polling should already work.

Sure, that makes sense for me.

>
> It's very unclear what format @driver_data has. I kept it for compatibility with android, but it's not clear to me how a userspace consumer would print it.
> Is there a usecase for this, or could it be removed from fence and sync_file?

I don't have any usecase for this. I'd say we remove it for now and if
someone needs this in the future we can talk about this again.

Gustavo

\
 
 \ /
  Last update: 2016-01-27 18:41    [W:0.075 / U:0.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site