Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] regmap: mmio: Convert to regmap_bus and fix accessor usage | Date | Wed, 27 Jan 2016 16:51:11 +0100 |
| |
On Wednesday 27 January 2016 15:34:09 Mark Brown wrote: > --- > drivers/base/regmap/regmap-mmio.c | 261 ++++++++++++++++++++------------------ > 1 file changed, 140 insertions(+), 121 deletions(-)
Overall looks good to me, but one bug:
> + > +#ifdef __64BIT > +static void regmap_mmio_write64le(struct regmap_mmio_context *ctx, > + unsigned int reg, > + unsigned int val) > +{ > + writeq(val, ctx->regs + reg); > +} > +#endif
s/__64BIT/CONFIG_64BIT/
here and in one other line.
Arnd
| |