lkml.org 
[lkml]   [2016]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator
    On Wed, Jan 27, 2016 at 01:00:59PM +0100, John Crispin wrote:

    > + /* Constrain board-specific capabilities according to what
    > + * this driver and the chip itself can actually do.
    > + */
    > + c = rdev->constraints;
    > + c->valid_modes_mask |= REGULATOR_MODE_NORMAL |
    > + REGULATOR_MODE_STANDBY;
    > + c->valid_ops_mask |= REGULATOR_CHANGE_MODE;

    No, drivers should *never* enable things that weren't explictly enabled
    by the machine constraints. This misses the whole point of having
    constraints. They are there so that the system integrator can enable
    the functionality that is safe on a given board.

    The comment is also inaccurate, it claims it's imposing constraints but
    in fact it's adding additional permissions.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2016-01-27 16:01    [W:3.837 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site