lkml.org 
[lkml]   [2016]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH V4 09/11] soc: mediatek: PMIC wrap: add a slave specific struct
    From
    Date
    Hi John,

    On Wed, 2016-01-27 at 12:29 +0100, John Crispin wrote:

    > @@ -746,7 +786,7 @@ static int pwrap_init(struct pmic_wrapper *wrp)
    > pwrap_writel(wrp, 1, PWRAP_DIO_EN);
    >
    > /* Read Test */
    > - pwrap_read(wrp, PWRAP_DEW_READ_TEST, &rdata);
    > + pwrap_dew_read(wrp, PWRAP_DEW_READ_TEST, &rdata);
    > if (rdata != PWRAP_DEW_READ_TEST_VAL) {
    > dev_err(wrp->dev, "Read test failed after switch to DIO mode: 0x%04x != 0x%04x\n",
    > PWRAP_DEW_READ_TEST_VAL, rdata);
    > @@ -759,12 +799,13 @@ static int pwrap_init(struct pmic_wrapper *wrp)
    > return ret;
    >
    > /* Signature checking - using CRC */
    > - if (pwrap_write(wrp, PWRAP_DEW_CRC_EN, 0x1))
    > + if (pwrap_dew_write(wrp, PWRAP_DEW_CRC_EN, 0x1))
    > return -EFAULT;
    >
    > pwrap_writel(wrp, 0x1, PWRAP_CRC_EN);
    > pwrap_writel(wrp, 0x0, PWRAP_SIG_MODE);
    > - pwrap_writel(wrp, PWRAP_DEW_CRC_VAL, PWRAP_SIG_ADR);
    > + pwrap_writel(wrp, wrp->slave->dew_regs[PWRAP_DEW_CRC_VAL],
    > + PWRAP_SIG_ADR);

    It should be "pwrap_dew_write(wrp, PWRAP_DEW_CRC_VAL, PWRAP_SIG_ADR);",
    right?

    Henry

    > pwrap_writel(wrp, wrp->master->arb_en_all, PWRAP_HIPRIO_ARB_EN);
    >
    > if (wrp->master->type == PWRAP_MT8135)



    \
     
     \ /
      Last update: 2016-01-28 03:41    [W:4.669 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site