lkml.org 
[lkml]   [2016]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] input: xpad: remove unused function
    On Mon, Jan 25, 2016 at 04:30:41PM +0100, Arnd Bergmann wrote:
    > There are two definitions of xpad_identify_controller(), one is used
    > when CONFIG_JOYSTICK_XPAD_LEDS is set, but the other one is empty
    > and never used, and we get a gcc warning about it:
    >
    > drivers/input/joystick/xpad.c:1210:13: warning: 'xpad_identify_controller' defined but not used [-Wunused-function]
    >
    > This removes the second definition.
    >
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > Fixes: cae705baa40b ("Input: xpad - re-send LED command on present event")

    Applied, thank you.

    > ---
    > drivers/input/joystick/xpad.c | 1 -
    > 1 file changed, 1 deletion(-)
    >
    > diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
    > index 6727954ab74b..e8a84d12b7ff 100644
    > --- a/drivers/input/joystick/xpad.c
    > +++ b/drivers/input/joystick/xpad.c
    > @@ -1207,7 +1207,6 @@ static void xpad_led_disconnect(struct usb_xpad *xpad)
    > #else
    > static int xpad_led_probe(struct usb_xpad *xpad) { return 0; }
    > static void xpad_led_disconnect(struct usb_xpad *xpad) { }
    > -static void xpad_identify_controller(struct usb_xpad *xpad) { }
    > #endif
    >
    > static int xpad_start_input(struct usb_xpad *xpad)
    > --
    > 2.7.0
    >

    --
    Dmitry

    \
     
     \ /
      Last update: 2016-01-28 01:01    [W:8.279 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site