lkml.org 
[lkml]   [2016]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC PATCH 08/21] mmc: sdhci-sirf: check sdhci_get_of_property return value
    Date
    sdhci_get_of_property may failed while probing, so we check
    the return value here.

    Cc: Barry Song <baohua@kernel.org>
    Cc: Weijun Yang <york.yang@csr.com>
    Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
    ---

    drivers/mmc/host/sdhci-sirf.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/mmc/host/sdhci-sirf.c b/drivers/mmc/host/sdhci-sirf.c
    index 34866f6..3f8499f 100644
    --- a/drivers/mmc/host/sdhci-sirf.c
    +++ b/drivers/mmc/host/sdhci-sirf.c
    @@ -195,7 +195,9 @@ static int sdhci_sirf_probe(struct platform_device *pdev)
    priv = sdhci_pltfm_priv(pltfm_host);
    priv->gpio_cd = gpio_cd;

    - sdhci_get_of_property(pdev);
    + ret = sdhci_get_of_property(pdev);
    + if (ret)
    + return ret;

    ret = clk_prepare_enable(pltfm_host->clk);
    if (ret)
    --
    2.3.7

    \
     
     \ /
      Last update: 2016-01-27 07:01    [W:5.444 / U:1.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site