lkml.org 
[lkml]   [2016]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2.y-ckt 133/268] scripts/bloat-o-meter: fix python3 syntax error
    Date
    4.2.8-ckt3 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>

    commit 72214a24a7677d4c7501eecc9517ed681b5f2db2 upstream.

    In Python3+ print is a function so the old syntax is not correct
    anymore:

    $ ./scripts/bloat-o-meter vmlinux.o vmlinux.o.old
    File "./scripts/bloat-o-meter", line 61
    print "add/remove: %s/%s grow/shrink: %s/%s up/down: %s/%s (%s)" % \
    ^
    SyntaxError: invalid syntax

    Fix by calling print as a function.

    Tested on python 2.7.11, 3.5.1

    Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    scripts/bloat-o-meter | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter
    index 23e78dc..38b64f4 100755
    --- a/scripts/bloat-o-meter
    +++ b/scripts/bloat-o-meter
    @@ -58,8 +58,8 @@ for name in common:
    delta.sort()
    delta.reverse()

    -print "add/remove: %s/%s grow/shrink: %s/%s up/down: %s/%s (%s)" % \
    - (add, remove, grow, shrink, up, -down, up-down)
    -print "%-40s %7s %7s %+7s" % ("function", "old", "new", "delta")
    +print("add/remove: %s/%s grow/shrink: %s/%s up/down: %s/%s (%s)" % \
    + (add, remove, grow, shrink, up, -down, up-down))
    +print("%-40s %7s %7s %+7s" % ("function", "old", "new", "delta"))
    for d, n in delta:
    - if d: print "%-40s %7s %7s %+7d" % (n, old.get(n,"-"), new.get(n,"-"), d)
    + if d: print("%-40s %7s %7s %+7d" % (n, old.get(n,"-"), new.get(n,"-"), d))
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-01-27 23:01    [W:6.317 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site