lkml.org 
[lkml]   [2016]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 25/26] perf hists browser: Skip scripting when perf.data file not available
    Date
    From: Namhyung Kim <namhyung@kernel.org>

    The script and data-switch context menu are only meaningful when it
    deals with a data file. So add a check so that it cannot be shown when
    perf-top is run.

    Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Andi Kleen <andi@firstfloor.org>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Jiri Olsa <jolsa@kernel.org>,
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: Wang Nan <wangnan0@huawei.com>
    Link: http://lkml.kernel.org/r/1453555902-18401-4-git-send-email-namhyung@kernel.org
    [ Carved out from a larger patch ]
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/ui/browsers/hists.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
    index d07e6be42ab1..1da30f8aa7a5 100644
    --- a/tools/perf/ui/browsers/hists.c
    +++ b/tools/perf/ui/browsers/hists.c
    @@ -2303,6 +2303,9 @@ skip_annotation:
    &options[nr_options],
    socked_id);
    /* perf script support */
    + if (!is_report_browser(hbt))
    + goto skip_scripting;
    +
    if (browser->he_selection) {
    if (sort__has_thread && thread) {
    nr_options += add_script_opt(browser,
    @@ -2330,6 +2333,7 @@ skip_annotation:
    &options[nr_options], NULL, NULL);
    nr_options += add_switch_opt(browser, &actions[nr_options],
    &options[nr_options]);
    +skip_scripting:
    nr_options += add_exit_opt(browser, &actions[nr_options],
    &options[nr_options]);

    --
    2.5.0
    \
     
     \ /
      Last update: 2016-01-26 21:01    [W:6.506 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site