Messages in this thread | | | Subject | Re: [linux-review:Jason-Baron/convert-dynamic_debug-to-use-jump-labels/20160126-055359] 30e241d11bfa30ea56c42028ef9776135d422b57 BUILD DONE | From | Jason Baron <> | Date | Tue, 26 Jan 2016 13:42:03 -0500 |
| |
Hi,
The x86 breakage depends on a 4.4 commit (153a433 x86/headers: Don't include asm/processor.h in asm/atomic.h), which appears missing in this tree.
However, the other arches are failing b/c the <linux/atomic.h> include in jump_label_branch.h is problematic as it eventually tries to pull in bug.h. So if bug.h is included it can try and pull it in again. Here is the powerpc spew for a 'allnoconfig' build:
In file included from include/linux/thread_info.h:54:0, from ./arch/powerpc/include/asm/ptrace.h:158, from ./arch/powerpc/include/asm/hw_irq.h:11, from ./arch/powerpc/include/asm/irqflags.h:11, from include/linux/irqflags.h:15, from include/asm-generic/cmpxchg-local.h:5, from ./arch/powerpc/include/asm/cmpxchg.h:304, from ./arch/powerpc/include/asm/atomic.h:10, from include/linux/atomic.h:4, from include/linux/jump_label_branch.h:47, from include/linux/dynamic_debug.h:4, from include/linux/printk.h:277, from include/linux/kernel.h:13, from include/asm-generic/bug.h:13, from ./arch/powerpc/include/asm/bug.h:127, from include/linux/bug.h:4, from include/linux/page-flags.h:9, from kernel/bounds.c:9: ./arch/powerpc/include/asm/thread_info.h: In function 'set_restore_sigmask': ./arch/powerpc/include/asm/thread_info.h:151:2: error: implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration] WARN_ON(!test_bit(TIF_SIGPENDING, &ti->flags));
The dependencies on linux/atomic.h for for the jump label enabled case are really only on 'ATOMIC_INIT()', which is defined on all arches as:
#define ATOMIC_INIT(i) { (i) }
So I'm not sure if there is interest in trying to pull that out to a common header, to make dependencies on atomic.h less problematic, but that will require changes for all arches.
Andrew - please revert this series until I work out these issues. Sorry for the noise.
Thanks,
-Jason
On 01/26/2016 12:30 AM, kbuild test robot wrote: > https://github.com/0day-ci/linux Jason-Baron/convert-dynamic_debug-to-use-jump-labels/20160126-055359 > 30e241d11bfa30ea56c42028ef9776135d422b57 dynamic_debug: add jump label support > > arch/powerpc/include/asm/bug.h:101:4: error: implicit declaration of function '__WARN' [-Werror=implicit-function-declaration] > arch/powerpc/include/asm/bug.h:107:24: error: 'TAINT_WARN' undeclared (first use in this function) > arch/powerpc/include/asm/bug.h:108:17: error: invalid application of 'sizeof' to incomplete type 'struct bug_entry' > arch/powerpc/include/asm/thread_info.h:151:2: error: implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration] > arch/powerpc/include/asm/thread_info.h:151:2: note: in expansion of macro 'WARN_ON' > arch/x86/include/asm/paravirt.h:25:2: note: in expansion of macro 'PVOP_VCALL2' > arch/x86/include/asm/paravirt_types.h:542:28: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration] > arch/x86/include/asm/paravirt_types.h:592:3: note: in expansion of macro 'PVOP_TEST_NULL' > arch/x86/include/asm/paravirt_types.h:604:2: note: in expansion of macro '____PVOP_VCALL' > arch/x86/include/asm/paravirt_types.h:641:2: note: in expansion of macro '__PVOP_VCALL' > include/linux/bitmap.h:186:22: note: in expansion of macro 'BITS_TO_LONGS' > include/linux/bitmap.h:186:3: error: implicit declaration of function 'DIV_ROUND_UP' [-Werror=implicit-function-declaration] > include/linux/bitops.h:13:27: error: implicit declaration of function 'DIV_ROUND_UP' [-Werror=implicit-function-declaration] > include/linux/cpumask.h:117:2: error: implicit declaration of function 'WARN_ON_ONCE' [-Werror=implicit-function-declaration] > include/linux/cpumask.h:15:41: error: variably modified 'bits' at file scope > include/linux/cpumask.h:708:29: error: variably modified 'cpu_all_bits' at file scope > include/linux/cpumask.h:712:29: error: variably modified 'cpu_all_bits' at file scope > include/linux/cpumask.h:754:2: error: variably modified 'cpu_bit_bitmap' at file scope > include/linux/cpumask.h:793:2: error: variably modified 'cpu_bit_bitmap' at file scope > include/linux/dynamic_debug.h:100:2: note: in expansion of macro 'static_branch_unlikely' > include/linux/dynamic_debug.h:119:6: note: in expansion of macro 'DDEBUG_BRANCH' > include/linux/jump_label_branch.h:183:59: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 8 has type 'dma_addr_t' [-Wformat=] > include/linux/jump_label_branch.h:51:2: error: implicit declaration of function 'atomic_read' [-Werror=implicit-function-declaration] > include/linux/jump_label_branch.h:51:9: error: implicit declaration of function 'atomic_read' [-Werror=implicit-function-declaration] > include/linux/thread_info.h:128:2: error: implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration] > include/linux/thread_info.h:129:2: error: implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration] > > Error ids grouped by kconfigs: > > recent_errors > ├── i386-randconfig-s0-201604 > │ ├── arch-x86-include-asm-paravirt.h:note:in-expansion-of-macro-PVOP_VCALL2 > │ ├── arch-x86-include-asm-paravirt_types.h:error:implicit-declaration-of-function-BUG_ON > │ ├── arch-x86-include-asm-paravirt_types.h:note:in-expansion-of-macro-PVOP_TEST_NULL > │ ├── arch-x86-include-asm-paravirt_types.h:note:in-expansion-of-macro-____PVOP_VCALL > │ ├── arch-x86-include-asm-paravirt_types.h:note:in-expansion-of-macro-__PVOP_VCALL > │ ├── include-linux-bitmap.h:note:in-expansion-of-macro-BITS_TO_LONGS > │ ├── include-linux-bitops.h:error:implicit-declaration-of-function-DIV_ROUND_UP > │ ├── include-linux-cpumask.h:error:variably-modified-bits-at-file-scope > │ ├── include-linux-cpumask.h:error:variably-modified-cpu_all_bits-at-file-scope > │ └── include-linux-cpumask.h:error:variably-modified-cpu_bit_bitmap-at-file-scope > ├── i386-randconfig-s1-201604 > │ ├── include-linux-bitmap.h:note:in-expansion-of-macro-BITS_TO_LONGS > │ ├── include-linux-bitops.h:error:implicit-declaration-of-function-DIV_ROUND_UP > │ ├── include-linux-cpumask.h:error:variably-modified-bits-at-file-scope > │ ├── include-linux-cpumask.h:error:variably-modified-cpu_all_bits-at-file-scope > │ └── include-linux-cpumask.h:error:variably-modified-cpu_bit_bitmap-at-file-scope > ├── i386-randconfig-x003-01251232 > │ ├── arch-x86-include-asm-paravirt.h:note:in-expansion-of-macro-PVOP_VCALL2 > │ ├── arch-x86-include-asm-paravirt_types.h:error:implicit-declaration-of-function-BUG_ON > │ ├── arch-x86-include-asm-paravirt_types.h:note:in-expansion-of-macro-PVOP_TEST_NULL > │ ├── arch-x86-include-asm-paravirt_types.h:note:in-expansion-of-macro-____PVOP_VCALL > │ └── arch-x86-include-asm-paravirt_types.h:note:in-expansion-of-macro-__PVOP_VCALL > ├── i386-tinyconfig > │ ├── include-linux-bitmap.h:note:in-expansion-of-macro-BITS_TO_LONGS > │ ├── include-linux-bitops.h:error:implicit-declaration-of-function-DIV_ROUND_UP > │ ├── include-linux-cpumask.h:error:variably-modified-bits-at-file-scope > │ ├── include-linux-cpumask.h:error:variably-modified-cpu_all_bits-at-file-scope > │ └── include-linux-cpumask.h:error:variably-modified-cpu_bit_bitmap-at-file-scope > ├── m68k-allyesconfig > │ └── include-linux-thread_info.h:error:implicit-declaration-of-function-WARN_ON > ├── m68k-m5475evb_defconfig > │ └── include-linux-thread_info.h:error:implicit-declaration-of-function-WARN_ON > ├── m68k-multi_defconfig > │ └── include-linux-thread_info.h:error:implicit-declaration-of-function-WARN_ON > ├── m68k-sun3_defconfig > │ └── include-linux-thread_info.h:error:implicit-declaration-of-function-WARN_ON > ├── mips-allnoconfig > │ └── include-linux-jump_label_branch.h:error:implicit-declaration-of-function-atomic_read > ├── mips-defconfig > │ └── include-linux-jump_label_branch.h:error:implicit-declaration-of-function-atomic_read > ├── mips-fuloong2e_defconfig > │ └── include-linux-jump_label_branch.h:error:implicit-declaration-of-function-atomic_read > ├── mips-jz4740 > │ └── include-linux-jump_label_branch.h:error:implicit-declaration-of-function-atomic_read > ├── mips-lemote2f_defconfig > │ └── include-linux-jump_label_branch.h:error:implicit-declaration-of-function-atomic_read > ├── mips-maltasmvp_eva_defconfig > │ └── include-linux-jump_label_branch.h:error:implicit-declaration-of-function-atomic_read > ├── mips-msp71xx_defconfig > │ └── include-linux-jump_label_branch.h:error:implicit-declaration-of-function-atomic_read > ├── mips-mtx1_defconfig > │ └── include-linux-jump_label_branch.h:error:implicit-declaration-of-function-atomic_read > ├── mips-tb0287_defconfig > │ └── include-linux-jump_label_branch.h:error:implicit-declaration-of-function-atomic_read > ├── mips-txx9 > │ └── include-linux-jump_label_branch.h:error:implicit-declaration-of-function-atomic_read > ├── mn10300-alldefconfig > │ ├── include-linux-bitmap.h:error:implicit-declaration-of-function-DIV_ROUND_UP > │ ├── include-linux-cpumask.h:error:variably-modified-bits-at-file-scope > │ ├── include-linux-cpumask.h:error:variably-modified-cpu_all_bits-at-file-scope > │ ├── include-linux-cpumask.h:error:variably-modified-cpu_bit_bitmap-at-file-scope > │ └── include-linux-thread_info.h:error:implicit-declaration-of-function-WARN_ON > ├── mn10300-asb2364_defconfig > │ ├── include-linux-bitmap.h:error:implicit-declaration-of-function-DIV_ROUND_UP > │ ├── include-linux-cpumask.h:error:variably-modified-bits-at-file-scope > │ ├── include-linux-cpumask.h:error:variably-modified-cpu_all_bits-at-file-scope > │ ├── include-linux-cpumask.h:error:variably-modified-cpu_bit_bitmap-at-file-scope > │ └── include-linux-thread_info.h:error:implicit-declaration-of-function-WARN_ON > ├── powerpc-allnoconfig > │ └── arch-powerpc-include-asm-thread_info.h:error:implicit-declaration-of-function-WARN_ON > ├── powerpc-cm5200_defconfig > │ ├── arch-powerpc-include-asm-bug.h:error:implicit-declaration-of-function-__WARN > │ ├── arch-powerpc-include-asm-bug.h:error:invalid-application-of-sizeof-to-incomplete-type-struct-bug_entry > │ ├── arch-powerpc-include-asm-bug.h:error:TAINT_WARN-undeclared-(first-use-in-this-function) > │ └── arch-powerpc-include-asm-thread_info.h:note:in-expansion-of-macro-WARN_ON > ├── powerpc-ep405_defconfig > │ ├── arch-powerpc-include-asm-bug.h:error:implicit-declaration-of-function-__WARN > │ ├── arch-powerpc-include-asm-bug.h:error:invalid-application-of-sizeof-to-incomplete-type-struct-bug_entry > │ ├── arch-powerpc-include-asm-bug.h:error:TAINT_WARN-undeclared-(first-use-in-this-function) > │ └── arch-powerpc-include-asm-thread_info.h:note:in-expansion-of-macro-WARN_ON > ├── powerpc-mpc834x_mds_defconfig > │ ├── arch-powerpc-include-asm-bug.h:error:implicit-declaration-of-function-__WARN > │ ├── arch-powerpc-include-asm-bug.h:error:invalid-application-of-sizeof-to-incomplete-type-struct-bug_entry > │ ├── arch-powerpc-include-asm-bug.h:error:TAINT_WARN-undeclared-(first-use-in-this-function) > │ └── arch-powerpc-include-asm-thread_info.h:note:in-expansion-of-macro-WARN_ON > ├── powerpc-pmac32_defconfig > │ ├── arch-powerpc-include-asm-bug.h:error:implicit-declaration-of-function-__WARN > │ ├── arch-powerpc-include-asm-bug.h:error:invalid-application-of-sizeof-to-incomplete-type-struct-bug_entry > │ ├── arch-powerpc-include-asm-bug.h:error:TAINT_WARN-undeclared-(first-use-in-this-function) > │ └── arch-powerpc-include-asm-thread_info.h:note:in-expansion-of-macro-WARN_ON > ├── powerpc-sbc8548_defconfig > │ ├── arch-powerpc-include-asm-bug.h:error:implicit-declaration-of-function-__WARN > │ ├── arch-powerpc-include-asm-bug.h:error:invalid-application-of-sizeof-to-incomplete-type-struct-bug_entry > │ ├── arch-powerpc-include-asm-bug.h:error:TAINT_WARN-undeclared-(first-use-in-this-function) > │ └── arch-powerpc-include-asm-thread_info.h:note:in-expansion-of-macro-WARN_ON > ├── s390-allyesconfig > │ └── include-linux-jump_label_branch.h:error:implicit-declaration-of-function-atomic_read > ├── sparc64-allmodconfig > │ ├── include-linux-dynamic_debug.h:note:in-expansion-of-macro-DDEBUG_BRANCH > │ ├── include-linux-dynamic_debug.h:note:in-expansion-of-macro-static_branch_unlikely > │ └── include-linux-jump_label_branch.h:warning:format-llx-expects-argument-of-type-long-long-unsigned-int-but-argument-has-type-dma_addr_t > └── x86_64-randconfig-x010-01250526 > └── include-linux-cpumask.h:error:implicit-declaration-of-function-WARN_ON_ONCE > > elapsed time: 455m > > configs tested: 167 > > alpha defconfig > parisc allnoconfig > parisc c3000_defconfig > parisc defconfig > i386 randconfig-a0-01260321 > i386 randconfig-a0-01260824 > x86_64 randconfig-a0-01260517 > x86_64 randconfig-a0-01260824 > arm hackkit_defconfig > powerpc mpc834x_mds_defconfig > sh se7722_defconfig > sh allnoconfig > sh rsk7269_defconfig > sh sh7785lcr_32bit_defconfig > sh titan_defconfig > arm allnoconfig > arm at91_dt_defconfig > arm at_hdmac > arm ep93xx > arm imx_v6_v7_defconfig > arm iop-adma > arm marzen_defconfig > arm prima2_defconfig > arm sa1100 > arm samsung > arm sh > arm spear13xx_defconfig > mips msp71xx_defconfig > powerpc pmac32_defconfig > tile defconfig > powerpc allnoconfig > powerpc defconfig > powerpc ppc64_defconfig > x86_64 acpi-redef > x86_64 allyesdebian > x86_64 nfsroot > m32r m32104ut_defconfig > m32r mappi3.smp_defconfig > m32r opsput_defconfig > m32r usrv_defconfig > xtensa common_defconfig > xtensa iss_defconfig > parisc b180_defconfig > blackfin BF526-EZBRD_defconfig > blackfin BF533-EZKIT_defconfig > blackfin BF561-EZKIT-SMP_defconfig > blackfin TCM-BF537_defconfig > cris etrax-100lx_v2_defconfig > i386 allmodconfig > frv allnoconfig > mips tb0287_defconfig > powerpc mpc8641_hpcn_defconfig > powerpc obs600_defconfig > powerpc ppc44x_defconfig > blackfin defconfig > ia64 defconfig > mips defconfig > sh defconfig > x86_64 randconfig-x010-01250526 > x86_64 randconfig-x019-01250526 > x86_64 randconfig-x016-01250526 > x86_64 randconfig-x015-01250526 > x86_64 randconfig-x012-01250526 > x86_64 randconfig-x018-01250526 > x86_64 randconfig-x017-01250526 > x86_64 randconfig-x013-01250526 > x86_64 randconfig-x011-01250526 > x86_64 randconfig-x014-01250526 > x86_64 randconfig-x010-01260845 > x86_64 randconfig-x011-01260845 > x86_64 randconfig-x012-01260845 > x86_64 randconfig-x013-01260845 > x86_64 randconfig-x014-01260845 > x86_64 randconfig-x015-01260845 > x86_64 randconfig-x016-01260845 > x86_64 randconfig-x017-01260845 > x86_64 randconfig-x018-01260845 > x86_64 randconfig-x019-01260845 > i386 alldefconfig > i386 allnoconfig > i386 defconfig > m68k m5475evb_defconfig > m68k multi_defconfig > m68k sun3_defconfig > i386 randconfig-s0-201604 > i386 randconfig-s1-201604 > i386 randconfig-s0-01260845 > i386 randconfig-s1-01260845 > x86_64 randconfig-s0-01260845 > x86_64 randconfig-s1-01260845 > x86_64 randconfig-s2-01260845 > x86_64 allmodconfig > x86_64 randconfig-s3-01260650 > x86_64 randconfig-s4-01260650 > x86_64 randconfig-s5-01260650 > avr32 atngw100_defconfig > avr32 atstk1006_defconfig > frv defconfig > mn10300 asb2364_defconfig > openrisc or1ksim_defconfig > tile tilegx_defconfig > um i386_defconfig > um x86_64_defconfig > i386 tinyconfig > mips allnoconfig > mips fuloong2e_defconfig > mips jz4740 > mips txx9 > x86_64 randconfig-i0-201604 > sparc defconfig > sparc64 allnoconfig > sparc64 defconfig > microblaze mmu_defconfig > microblaze nommu_defconfig > i386 randconfig-i0-01251419 > i386 randconfig-i1-01251419 > i386 randconfig-i0-01260827 > i386 randconfig-i1-01260827 > x86_64 randconfig-b0-01260827 > mips maltasmvp_eva_defconfig > powerpc cm5200_defconfig > sh se7780_defconfig > sparc64 allmodconfig > arm arm5 > arm arm67 > arm mmp > arm omap2plus_defconfig > arm s3c2410_defconfig > arm tegra_defconfig > x86_64 lkp > x86_64 rhel > i386 randconfig-n0-201604 > i386 randconfig-h0-01260743 > i386 randconfig-h1-01260743 > ia64 alldefconfig > ia64 allnoconfig > mips lemote2f_defconfig > powerpc sbc8548_defconfig > x86_64 randconfig-n0-01260604 > arm lart_defconfig > powerpc ep405_defconfig > i386 randconfig-sb0-01260633 > mips mtx1_defconfig > mn10300 alldefconfig > sh sdk7786_defconfig > x86_64 randconfig-x000-01250410 > x86_64 randconfig-x001-01250410 > x86_64 randconfig-x002-01250410 > x86_64 randconfig-x003-01250410 > x86_64 randconfig-x004-01250410 > x86_64 randconfig-x005-01250410 > x86_64 randconfig-x006-01250410 > x86_64 randconfig-x007-01250410 > x86_64 randconfig-x008-01250410 > x86_64 randconfig-x009-01250410 > i386 randconfig-r0-201604 > i386 randconfig-x002-01251232 > i386 randconfig-x008-01251232 > i386 randconfig-x006-01251232 > i386 randconfig-x000-01251232 > i386 randconfig-x004-01251232 > i386 randconfig-x001-01251232 > i386 randconfig-x005-01251232 > i386 randconfig-x009-01251232 > i386 randconfig-x003-01251232 > i386 randconfig-x007-01251232 > i386 randconfig-x0-01260745 > > Thanks, > Fengguang >
| |