lkml.org 
[lkml]   [2016]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4 07/10] rtc: max77686: Fix unsupported year message
    From
    Date
    On 27.01.2016 12:36, Javier Martinez Canillas wrote:
    > The max77686 RTC only supports a range of 99 years so instead of using
    > year 1900 as the base, the year 2000 is used. This means that 1900 to
    > 1999 are unsupported years.
    >
    > The driver was printing a warning for those values but was returning a
    > error so for consistency, print an error message instead and don't say
    > that a year 2000 is assumed, since the year is not set.
    >
    > Also, it is better to use dev_* log functions instead of pr_* to print
    > information about the device in the kernel log in a standardized way.
    >
    > This also allows to remove the local pr_fmt() defined macro.
    >
    > Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
    > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
    >
    > ---
    >
    > Changes in v4:
    > - Use dev_err() instead of dev_warn() and change message.
    > Suggested by Krzysztof Kozlowski and Andi Shyti.
    > - Change subject line and commit message of patch #7.
    > - Removed Laxman Dewangan's Acked-by tag since the patch changed.
    >
    > Changes in v3:
    > - Add Laxman Dewangan's Acked-by tag to patch #7.
    >
    > Changes in v2: None
    >
    > drivers/rtc/rtc-max77686.c | 4 +---
    > 1 file changed, 1 insertion(+), 3 deletions(-)

    Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

    Best regards,
    Krzysztof


    \
     
     \ /
      Last update: 2016-01-27 05:41    [W:3.785 / U:0.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site