Messages in this thread | | | Date | Mon, 25 Jan 2016 13:55:47 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH] clk: tegra: clk-emc: Add missing of_node_put |
| |
On Sun, Jan 24, 2016 at 08:45:20PM +0530, Amitoj Kaur Chawla wrote: > for_each_child_of_node performs an of_node_get on each iteration, so > to break out of the loop an of_node_put is required. > > Found using Coccinelle. The semantic patch used for this is as follows: > > // <smpl> > @@ > expression e; > local idexpression child; > @@ > > for_each_child_of_node(root, child) { > ... when != of_node_put(child) > when != e = child > ( > return child; > | > + of_node_put(child); > ? return ...; > ) > ... > } > // </smpl> > > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> > --- > drivers/clk/tegra/clk-emc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry [unhandled content-type:application/pgp-signature] | |