lkml.org 
[lkml]   [2016]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/1] mfd: intel-lpss: remove clock tree on error path
On Fri, 22 Jan 2016, Andy Shevchenko wrote:

> We forgot to remove the clock tree if something goes wrong in ->probe(). Add a
> call to intel_lpss_unregister_clock() on error path in ->probe() to fix the
> potential issue.
>
> Fixes: 4b45efe85263 (mfd: Add support for Intel Sunrisepoint LPSS devices)
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mfd/intel-lpss.c | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
> index 2a7c6a7..807a3e3 100644
> --- a/drivers/mfd/intel-lpss.c
> +++ b/drivers/mfd/intel-lpss.c
> @@ -455,6 +455,7 @@ int intel_lpss_probe(struct device *dev,
> err_remove_ltr:
> intel_lpss_debugfs_remove(lpss);
> intel_lpss_ltr_hide(lpss);
> + intel_lpss_unregister_clock(lpss);
>
> err_clk_register:
> ida_simple_remove(&intel_lpss_devid_ida, lpss->devid);

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2016-01-25 13:21    [W:0.037 / U:0.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site