Messages in this thread | | | Date | Mon, 25 Jan 2016 11:26:43 +0100 | From | Robert Richter <> | Subject | Re: [PATCH v3 12/12] acpi, numa: reuse acpi_numa_memory_affinity_init() |
| |
On 23.01.16 17:39:27, Hanjun Guo wrote: > From: Hanjun Guo <hanjun.guo@linaro.org> > > After the cleanup for acpi_numa_memory_affinity_init(), > it can be used for architetures both x86 and arm64, since > CONFIG_MEMORY_HOTPLUG is not enabled for arm64, so no > worry about that. > > Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org> > --- > arch/arm64/kernel/acpi_numa.c | 42 ------------------------------- > arch/x86/mm/srat.c | 54 ---------------------------------------- > drivers/acpi/numa.c | 57 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 57 insertions(+), 96 deletions(-)
This one reverts acpi_numa_memory_affinity_init() to the x86 version. I rather would prefer the arm64 version for the generic code. We could keep the x86 implementation until x86 maintainers agree to remove them and use the generic one (implemented in a separate patch).
Doing so we can move acpi_numa_memory_affinity_init() from the beginning to generic code (used for arm64) and have this last patch to remove the x86 version.
-Robert
| |