Messages in this thread | | | Date | Tue, 19 Jan 2016 18:03:39 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [RFC/PATCHSET 00/17] perf tools: Add support for hierachy view (v2) |
| |
Em Tue, Jan 19, 2016 at 07:45:06PM +0900, Namhyung Kim escreveu: > Hi Andi, > > On Sun, Jan 17, 2016 at 08:31:53PM +0100, Andi Kleen wrote: > > On Sun, Jan 17, 2016 at 01:03:00AM +0900, Namhyung Kim wrote: > > > Hello, > > > > > > This is v2 attempt of my earlier patchset [1]. This patchset > > > implements a new feature that collects hist entries in a hierachical > > > manner. That means lower-level entries belong to an upper-level > > > entry. The entry hierachy is built on the sort keys given, so users > > > can set it whatever they want. It only shows top-level entries first, > > > and user can expand/collapse it dynamically. > > > > Thanks that's very nice. Especially for TSX profiling it was always > > very annoying that the other sort keys didn't actually sort. > > It should be very useful for LBR view too. > > Glad to hear that you like it. :) > > > > > > Now we only need a better percent-limit that handles all > > leaves correctly... > > Hmm.. could you tell me where the percent-limit doesn't work > correctly?
Yeah, please elaborate, I'm testing:
perf top -s comm,dso,sym --hierarchy --percent-limit 0.5
And it seems to work...
- Arnaldo
| |