lkml.org 
[lkml]   [2016]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH v1] refining the rpm_suspend function
Date
On Tuesday, January 19, 2016 05:14:18 PM Zhaoyang Huang wrote:
> There are too many branch path within he original rpm_suspend funciton,which make
> the code a little bit hard for understanding and debugging.Just try to split the
> function into some small one to eliminate the goto and make one optimization for
> avoiding transfering from wait to auto when irq_safe flag set
>
> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@spreadtrum.com>

First off, please don't mix cleanups with optimizations.

Second, I don't really think that the changes you're making improve things
from the readability/debugging viewpoint.

Thanks,
Rafael


\
 
 \ /
  Last update: 2016-01-19 15:21    [W:0.062 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site