Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [RFC PATCH v1] refining the rpm_suspend function | Date | Tue, 19 Jan 2016 14:49:15 +0100 |
| |
On Tuesday, January 19, 2016 05:14:18 PM Zhaoyang Huang wrote: > There are too many branch path within he original rpm_suspend funciton,which make > the code a little bit hard for understanding and debugging.Just try to split the > function into some small one to eliminate the goto and make one optimization for > avoiding transfering from wait to auto when irq_safe flag set > > Signed-off-by: Zhaoyang Huang <zhaoyang.huang@spreadtrum.com>
First off, please don't mix cleanups with optimizations.
Second, I don't really think that the changes you're making improve things from the readability/debugging viewpoint.
Thanks, Rafael
| |