Messages in this thread | | | Date | Mon, 18 Jan 2016 17:11:23 -0800 | Subject | Re: [PATCH 2/2] clk: s2mps11: allocate only one structure for clock init | From | Yadwinder Singh Brar <> |
| |
>> >> IMHO, with all these modifications, it will leave driver with some extra >> checks and reduced readability, perhaps will make it complex to add >> support for similar clocks but with different clk_ops, if next version or >> any similar mfd chip comes up in future. > > There is no evidence that some future chip will require clk_ops. All of > them are so far exactly the same. Even the newly added S2MPS15 is the same. >
Can we guaranty about future chips? Even we didn't expect there will be one less clock in case of s2mps14.
> This really should be simplified. >
IMO, it is just reduction of LoC.
Regards, Yadwinder
| |