Messages in this thread | | | Date | Mon, 18 Jan 2016 15:06:49 +0100 | From | Borislav Petkov <> | Subject | Re: [RFC PATCH] x86/kconfig: Sanity-check config file during oldconfig |
| |
On Mon, Jan 18, 2016 at 02:36:09PM +0100, Thomas Voegtle wrote: > My problem was, CONFIG_MICROCODE got dropped silently, and yes that is > fixed for me with this patch. But I think this is a little bit odd way > to fix it, but I don't have a better idea.
Me neither. The problem is, I need to grep the config that goes into the "oldconfig" *before* scripts/kconfig/conf gets a hold of it and satisfies deps and thus turns off CONFIG_MICROCODE in the process. This is a simpler solution short of hacking scripts/kconfig/conf and it can be used for other stuff we might need in arch/x86/
> What's with olddefconfig
Yes, I'll update the patch.
> and silentoldconfig ?
This one is funny. Makefile's help says:
silentoldconfig - Same as oldconfig, but quietly, additionally update deps
and yet doing
$ make silentoldconfig
is not very silent and goes through all new prompts asking me about them.
Regarding this issue, yes, I'll add its name to the script too.
> btw that patch has to go to stable 4.4, too
Sure, once we agree on the approach.
Thanks.
-- Regards/Gruss, Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --
| |