lkml.org 
[lkml]   [2016]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] driver-core: platform: automatically mark wakeup devices
    On Sun, Jan 17, 2016 at 09:11:25PM -0800, Greg Kroah-Hartman wrote:
    > On Sun, Jan 17, 2016 at 06:11:38PM -0800, Dmitry Torokhov wrote:
    > > When probing platform drivers let's check if corresponding devices have
    > > "wakeup-source" property defined (either in device tree, ACPI, or static
    > > platform properties) and automatically enable such devices as wakeup
    > > sources for the system. This will help us standardize on the name for this
    > > property and reduce amount of boilerplate code in the drivers.
    >
    > How much boilerplate code can be removed? Do you have an example patch
    > of this removal for any drivers if we move this logic into the driver core?

    Admittedly not a lot, a few lines. There is a couple of lines for
    checking the property and calling device_init_wakeup() and also
    sometimes clearing wakeup flag is the only thing that is left in
    remove() method after converting to devm*. I am more interested in
    standardizing on the property name and having wakeup flag cleared on
    removal or probe failure, similarly how we do it for driver data in
    device structure.

    I do not have good patches in input at the moment as even though we are
    using "wakeup-source" now lots if the drivers did not start with it and
    so we have compatibility parsing still that we want to keep around. I
    want the new drivers to use only this property though.

    FWIW I2C bus code implements automatic parsing of this property as well
    and I wonder if we want to do the same for SPI.

    Thanks.

    --
    Dmitry

    \
     
     \ /
      Last update: 2016-01-18 07:41    [W:2.406 / U:0.736 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site