lkml.org 
[lkml]   [2016]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 39/70] net/core: revert "net: fix __netdev_update_features return.." and add comment
    3.2.76-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>

    commit 17b85d29e82cc3c874a497a8bc5764d6a2b043e2 upstream.

    This reverts commit 00ee59271777 ("net: fix __netdev_update_features return
    on ndo_set_features failure")
    and adds a comment explaining why it's okay to return a value other than
    0 upon error. Some drivers might actually change flags and return an
    error so it's better to fire a spurious notification rather than miss
    these.

    CC: Michał Mirosław <mirq-linux@rere.qmqm.pl>
    Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    net/core/dev.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/net/core/dev.c
    +++ b/net/core/dev.c
    @@ -5446,7 +5446,10 @@ int __netdev_update_features(struct net_
    netdev_err(dev,
    "set_features() failed (%d); wanted 0x%08x, left 0x%08x\n",
    err, features, dev->features);
    - return 0;
    + /* return non-0 since some features might have changed and
    + * it's better to fire a spurious notification than miss it
    + */
    + return -1;
    }

    if (!err)

    \
     
     \ /
      Last update: 2016-01-18 05:01    [W:2.741 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site