lkml.org 
[lkml]   [2016]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 30/70] USB: ipaq.c: fix a timeout loop
    3.2.76-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit abdc9a3b4bac97add99e1d77dc6d28623afe682b upstream.

    The code expects the loop to end with "retries" set to zero but, because
    it is a post-op, it will end set to -1. I have fixed this by moving the
    decrement inside the loop.

    Fixes: 014aa2a3c32e ('USB: ipaq: minor ipaq_open() cleanup.')
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/serial/ipaq.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/usb/serial/ipaq.c
    +++ b/drivers/usb/serial/ipaq.c
    @@ -582,7 +582,8 @@ static int ipaq_open(struct tty_struct *
    * through. Since this has a reasonably high failure rate, we retry
    * several times.
    */
    - while (retries--) {
    + while (retries) {
    + retries--;
    result = usb_control_msg(serial->dev,
    usb_sndctrlpipe(serial->dev, 0), 0x22, 0x21,
    0x1, 0, NULL, 0, 100);

    \
     
     \ /
      Last update: 2016-01-18 05:01    [W:4.308 / U:0.480 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site