lkml.org 
[lkml]   [2016]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 15/70] spi: fix parent-device reference leak
    3.2.76-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit 157f38f993919b648187ba341bfb05d0e91ad2f6 upstream.

    Fix parent-device reference leak due to SPI-core taking an unnecessary
    reference to the parent when allocating the master structure, a
    reference that was never released.

    Note that driver core takes its own reference to the parent when the
    master device is registered.

    Fixes: 49dce689ad4e ("spi doesn't need class_device")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/spi/spi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/spi/spi.c
    +++ b/drivers/spi/spi.c
    @@ -554,7 +554,7 @@ struct spi_master *spi_alloc_master(stru

    device_initialize(&master->dev);
    master->dev.class = &spi_master_class;
    - master->dev.parent = get_device(dev);
    + master->dev.parent = dev;
    spi_master_set_devdata(master, &master[1]);

    return master;

    \
     
     \ /
      Last update: 2016-01-18 05:01    [W:7.971 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site