lkml.org 
[lkml]   [2016]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v7] iio: add ad5761 DAC driver
From
Date
On 01/11/2016 08:32 PM, Ricardo Ribalda Delgado wrote:
> ad5761 is a 1-channel DAC with configurable output range.
> The driver uses the regulator interface for its voltage ref.
>
> It shares its register layout with ad5761r, ad5721 and ad5721r.
>
> Differences:
> ad5761* are 16 bit, ad5721* are 12 bits.
> ad57*1r have an internal reference.
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>

Looks very clean now, thanks. I have just one comment I overlooked during
the first review. When that's addresses feel free to add

Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>

And one wish for the future, please give people a chance a review and don't
resend a new version of the patch every couple of hours. This will make the
reviewers life a bit easier.

> diff --git a/include/linux/iio/dac/ad5761.h b/include/linux/iio/dac/ad5761.h
> new file mode 100644
> index 000000000000..2f3702309d61
> --- /dev/null
> +++ b/include/linux/iio/dac/ad5761.h

This should go into include/linux/platform_data. That's where all new
platform data include files should go.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-01-12 09:21    [W:0.101 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site