lkml.org 
[lkml]   [2016]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v15 02/25] tools: Make list.h self-sufficient
Em Tue, Jan 12, 2016 at 01:35:40PM +0100, Borislav Petkov escreveu:
> On Fri, Dec 18, 2015 at 06:39:16AM -0600, Josh Poimboeuf wrote:
> > Commit 7f5f873c6a07 added the use of the WRITE_ONCE macro to the kernel
>
> nitpick: we like to do this commit quoting style:
>
> 7f5f873c6a07 ("rculist: Use WRITE_ONCE() when deleting from reader-visible list")
>
> Checkpatch catches that:
>
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit 7f5f873c6a07 ("rculist: Use WRITE_ONCE() when deleting from reader-visible list")'
> #21:
> Commit 7f5f873c6a07 added the use of the WRITE_ONCE macro to the kernel

I'm fixing this up and taking this patch, ok?

- Arnaldo

> > version of list.h, which broke the stacktool build because the tools
> > list.h includes the kernel list.h.
> >
> > Avoid this type of situation in the future and make list.h
> > self-sufficient by copying the kernel list.h routines directly into
> > tools list.h.
> >
> > This is a straight copy except for adjustments to the include statements
> > and copying of the tools-specific list routines (list_del_range and
> > list_for_each_from).
> >
> > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> > ---
> > tools/include/linux/list.h | 753 ++++++++++++++++++++++++++++++++++++++++++++-
> > 1 file changed, 747 insertions(+), 6 deletions(-)
>
> ...
>
> --
> Regards/Gruss,
> Boris.
>
> ECO tip #101: Trim your mails when you reply.

\
 
 \ /
  Last update: 2016-01-12 16:41    [W:0.213 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site