Messages in this thread | | | Date | Tue, 12 Jan 2016 11:24:26 -0300 | From | "" <> | Subject | Re: [PATCH 16/53 v2] perf tools: Fix mmap2 event allocation in synthesize code |
| |
Em Tue, Jan 12, 2016 at 06:51:07PM +0800, Wangnan (F) escreveu: > On 2016/1/12 18:49, 平松雅巳 / HIRAMATU,MASAMI wrote: > >>From: Wang Nan [mailto:wangnan0@huawei.com] > >>perf_event__synthesize_mmap_events() issues mmap2 events, but the > >>memory of that event is allocated using: > >> > >>mmap_event = malloc(sizeof(mmap_event->mmap) + machine->id_hdr_size); > >> > >>If path of mmap source file is long (near PATH_MAX), random crash > >>would happen. Should use sizeof(mmap_event->mmap2). > >> > >>Fix two memory allocations. > >Looks good to me. But hope to have another rename patch soon after this... > > According to Arnaldo, we don't need rename patch. He think mmap_event > is okay. Right?
Right, no need for the rename.
- Arnaldo
| |