| Date | Tue, 12 Jan 2016 14:57:52 +0530 | From | Viresh Kumar <> | Subject | Re: [RFC PATCH 04/19] cpufreq: bring data structures close to their locks |
| |
On 11-01-16, 23:07, Peter Zijlstra wrote: > On Mon, Jan 11, 2016 at 05:35:45PM +0000, Juri Lelli wrote: > > +/** > > + * Iterate over governors > > + * > > + * cpufreq_governor_list is protected by cpufreq_governor_mutex. > > + */ > > +static LIST_HEAD(cpufreq_governor_list); > > +static DEFINE_MUTEX(cpufreq_governor_mutex); > > +#define for_each_governor(__governor) \ > > + list_for_each_entry(__governor, &cpufreq_governor_list, governor_list) > > So you could stuff the lockdep_assert_held() you later add intididually > into the for_each_governor macro, impossible to forget that way.
How exactly? I couldn't see how it can be done in a neat and clean way.
-- viresh
|