lkml.org 
[lkml]   [2016]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v6] iio: add ad5761 DAC driver
Hello Jonathan

On Mon, Jan 11, 2016 at 8:24 PM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 11/01/16 16:23, Ricardo Ribalda Delgado wrote:
>> ad5761 is a 1-channel DAC with configurable output range.
>> The driver uses the regulator interface for its voltage ref.
>>
>> It shares its register layout with ad5761r, ad5721 and ad5721r.
>>
>> Differences:
>> ad5761* are 16 bit, ad5721* are 12 bits.
>> ad57*1r have an internal reference.
>>
>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> Just that unnecessary null check left as far as I'm concerned.
> I'd like to leave this a little while for others to take a look
> if they like as well.

Shall i send v7 with that fixed or I wait?


Regards!

\
 
 \ /
  Last update: 2016-01-11 21:21    [W:0.028 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site