lkml.org 
[lkml]   [2016]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[RESEND PATCH 1/3] vfs: show_vfsmnt: remove redundant initialization of error code
    Date: Wed Nov 18 21:07:10 2015 +0000

    As err variable is now always checked right after the first assignment,
    its initialization is redundant and could be safely removed.

    Suggested-by: Mateusz Guzik <mguzik@redhat.com>
    Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
    ---
    fs/proc_namespace.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/proc_namespace.c b/fs/proc_namespace.c
    index 876459559..cbc9c27 100644
    --- a/fs/proc_namespace.c
    +++ b/fs/proc_namespace.c
    @@ -95,9 +95,9 @@ static int show_vfsmnt(struct seq_file *m, struct vfsmount *mnt)
    {
    struct proc_mounts *p = m->private;
    struct mount *r = real_mount(mnt);
    - int err = 0;
    struct path mnt_path = { .dentry = mnt->mnt_root, .mnt = mnt };
    struct super_block *sb = mnt_path.dentry->d_sb;
    + int err;

    if (sb->s_op->show_devname) {
    err = sb->s_op->show_devname(m, mnt_path.dentry);
    --
    ldv

    \
     
     \ /
      Last update: 2016-01-11 16:41    [W:4.975 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site